oreolek/kohana-migrations
1
0
Fork 0
mirror of https://github.com/Oreolek/kohana-migrations.git synced 2024-06-26 03:40:54 +03:00
Code Issues Releases Wiki Activity

refactoring some of the code to prevent some errors (refs #22)

Browse source
This commit is contained in:
Lorenzo Pisani 2011-06-25 22:55:13 -07:00
parent 2cb4566e96
commit 5d3bf345ba
1 changed files with 28 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
classes/minion/task/db/generate.php
View file

@ -6,10 +6,10 @@
* Available config options are: * Available config options are:
* *
* --group=path/to/migration/group * --group=path/to/migration/group
* *
* This is a required config option, use it specify in which group the * This is a required config option, use it specify in which group the
* migration should be stored. Due to the nature of the cascading filesystem * migration should be stored. Due to the nature of the cascading filesystem
* minion doesn't automatically know where a migration is stored so make sure * minion doesn't automatically know where a migration is stored so make sure
* you pass in the full path to your migrations folder, e.g. * you pass in the full path to your migrations folder, e.g.
* *
* # The group of the migrations folder is modules/myapp/migrations/myapp/ * # The group of the migrations folder is modules/myapp/migrations/myapp/
@ -19,11 +19,11 @@
* *
* --description="Description of migration here" * --description="Description of migration here"
* *
* This is an arbitrary description of the migration, used to build the * This is an arbitrary description of the migration, used to build the
* filename. It is required but can be changed manually later on without * filename. It is required but can be changed manually later on without
* affecting the integrity of the migration. * affecting the integrity of the migration.
* *
* The description will be * The description will be
* *
* @author Matt Button <matthew@sigswitch.com> * @author Matt Button <matthew@sigswitch.com>
*/ */
@ -46,25 +46,28 @@ class Minion_Task_Db_Generate extends Minion_Task
*/ */
public function execute(array $config) public function execute(array $config)
{ {
$defaults = array(
'location' => APPPATH,
'description' => '',
'group' => NULL,
);
$config = array_merge($defaults, $config);
if (empty($config['group'])) if (empty($config['group']))
{ {
return 'Please provide --group'.PHP_EOL. return 'Please provide --group'.PHP_EOL.
'See help for more info'.PHP_EOL; 'See help for more info'.PHP_EOL;
} }
$group = $config['group'].'/'; $group = $config['group'].'/';
$description = $config['description']; $description = $config['description'];
if (empty($config['location']))
{
$config['location'] = APPPATH;
}
$location = rtrim(realpath($config['location']), '/').'/migrations/'; $location = rtrim(realpath($config['location']), '/').'/migrations/';
// {year}{month}{day}{hour}{minute}{second} // {year}{month}{day}{hour}{minute}{second}
$time = date('YmdHis'); $time = date('YmdHis');
$class = $this->_generate_classname($group, $time); $class = $this->_generate_classname($group, $time);
$file = $this->_generate_filename($location, $group, $time, $description); $file = $this->_generate_filename($location, $group, $time, $description);
$data = Kohana::FILE_SECURITY.View::factory('minion/task/db/generate/template') $data = Kohana::FILE_SECURITY.View::factory('minion/task/db/generate/template')
@ -93,7 +96,7 @@ class Minion_Task_Db_Generate extends Minion_Task
{ {
$class = ucwords(str_replace('/', ' ', $group)); $class = ucwords(str_replace('/', ' ', $group));
// If group is empty then we want to avoid double underscore in the // If group is empty then we want to avoid double underscore in the
// class name // class name
if ( ! empty($class)) if ( ! empty($class))
{ {
@ -115,8 +118,15 @@ class Minion_Task_Db_Generate extends Minion_Task
*/ */
public function _generate_filename($location, $group, $time, $description) public function _generate_filename($location, $group, $time, $description)
{ {
$description = substr(strtolower($description), 0, 100); // Max 100 characters, lowecase filenames.
return $location.$group.$time.'_'.preg_replace('~[^a-z]+~', '-', $description).EXT; $label = substr(strtolower($description), 0, 100);
// Only letters
$label = preg_replace('~[^a-z]+~', '-', $label);
// Add the location, group, and time
$filename = $location.$group.$time.'_'.$label;
// If description was empty, trim underscores
$filename = trim($filename, '_');
return $filename.EXT;
} }
} }